Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-resolve): Add exception to allow fallbacks when resolving exports fail. #1704

Closed
wants to merge 1 commit into from
Closed

fix(node-resolve): Add exception to allow fallbacks when resolving exports fail. #1704

wants to merge 1 commit into from
+27 −15

Conversation

tornadocontrib
Copy link

Allow exceptions to allow fallbacks for "exports" defined dependencies to allow them bundled.

Should address the following error

(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\eddsa.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\poseidon_opt.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\mimc7.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\babyjub.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\evmasm.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\mimcsponge.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\poseidon_wasm.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\pedersen_hash.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\poseidon_gencontract.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\smt.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\poseidon_reference.js using exports defined in node_modules\ffjavascript\package.json.
(!) [plugin node-resolve] Could not resolve import "ffjavascript" in node_modules\circomlibjs\src\smt_hashes_poseidon.js using exports defined in node_modules\ffjavascript\package.json.

@tornadocontrib tornadocontrib changed the title Add exception to allow fallbacks when resolving exports fail fix(node-resolve): Add exception to allow fallbacks when resolving exports fail Apr 15, 2024
@tornadocontrib tornadocontrib mentioned this pull request Apr 15, 2024
Open
@shellscape shellscape changed the title fix(node-resolve): Add exception to allow fallbacks when resolving exports fail fix(node-resolve): Add exception to allow fallbacks when resolving exports fail. Sep 22, 2024
shellscape
shellscape requested changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The changes you made looked good, but we'll need a test added specifically for this change before we can merge them.

@shellscape
Copy link
Collaborator

Closing as abandoned.

@shellscape shellscape closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellscape shellscape shellscape requested changes

@tjenkinson tjenkinson Awaiting requested review from tjenkinson tjenkinson is a code owner

@benmccann benmccann Awaiting requested review from benmccann

@guybedford guybedford Awaiting requested review from guybedford

@lukastaegert lukastaegert Awaiting requested review from lukastaegert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tornadocontrib @shellscape